Comments on: Quick Move

By: Dick Kusleika

Dick Kusleika — Sun, 09 Aug 2009 20:53:00 +0000

Yeah, that’s better. I need to name wb something different like wbOriginal or wbCaller and it will be even clearer. Thanks Bob.

By: Bob Phillips

Bob Phillips — Sun, 09 Aug 2009 17:30:00 +0000

Dick,

I realised why you captured it, just felt it looked odd. It is the sort of thing that the next guy who maintains the code might think, this sh variable is only used in one place, I can easily delete it and use ACtivesheet where it is used.

As you want to capture the original workbook to close, I would use

Set wb = ActiveSheet.Parent
If bNewWorkbook Then
ActiveSheet.Copy
Else
ActiveSheet.Copy shAfter
End If
wb.Close False
Else
If bNewWorkbook Then
ActiveSheet.Copy
Else
ActiveSheet.Copy shAfter
End If
End If

that way you use Activesheet which you think is clearer, you don't have the apparent inconsistency, and your intent is actually clearer.

All in the cause of 'Defensive Programming'

By: Dick Kusleika

Dick Kusleika — Sun, 09 Aug 2009 00:10:00 +0000

I want to use Activesheet. I store it in Sh so I can do the sh.Parent.Close after the activesheet has changed, but I think using Activesheet is clearer. I hadn’t thought about how that looks until you mention it. Good point on the optional argument – you don’t think I would ever forget an optional argument when I needed it do you?

By: Bob Phillips

Bob Phillips — Sat, 08 Aug 2009 11:05:00 +0000

Two comments on the moving sheets code.

You set sh to Activesheet, then continue to use Activesheet in the code.

shAfter is an optional argument, but you do not test in the code whether it is present or not and take mitigating action, so if it is not passed, the code could fail.

By: Hans Schraven

Hans Schraven — Fri, 07 Aug 2009 16:22:00 +0000

My idea:

Private Sub UserForm_Activate()
lbxWorkbooks.Tag = ""
For Each wb In Application.Windows
If wb.Parent.Name ActiveWorkbook.Name And wb.Visible Then lbxWorkbooks.Tag = lbxWorkbooks.Tag & wb.Parent.Name & "|"
Next
lbxWorkbooks.List = Split(lbxWorkbooks.Tag & "New Workbook", "|")

cmdCopy.Visible = lbxWorkbooks.ListCount > 0
cmdMove.Visible = cmdCopy.Visible

If lbxWorkbooks.ListCount > 0 Then lbxWorkbooks.Selected(0) = True
End Sub

Private Sub cmdCancel_Click()
Hide
End Sub

Private Sub cmdCopy_Click()
CopyMoveSheet
End Sub

Private Sub cmdMove_Click()
Application.DisplayAlerts = False
With ActiveSheet
cmdMove.Tag = .Parent.Name
cmdCopy.Tag = .Name
cmdCancel.Tag = .Parent.Path
End With

CopyMoveSheet

With Workbooks(cmdMove.Tag)
If InStr(".txt.csv", Right(cmdMove.Tag, 4)) > 0 Or cmdCancel.Tag = "" Then
.Close False
ElseIf .Sheets.Count > 1 Then
.Sheets(cmdCopy.Tag).Delete
End If
End With
End Sub

Private Sub CopyMoveSheet()
If lbxWorkbooks.Value = "New Workbook" Then
ActiveSheet.Copy
Else
With Workbooks(lbxWorkbooks.Value)
ActiveSheet.Copy , .Sheets(.Sheets.Count)
End With
End If
Hide
End Sub

By: JP

JP — Fri, 07 Aug 2009 15:11:00 +0000

You should set up a separate page with all your downloads. It will be easier than jumping around to different pages to find everything.