Comments on: Inflexible Find

By: Ian Scott

Ian Scott — Mon, 14 Feb 2011 14:54:00 +0000

You need to exclude hidden sheets so:

For Each sh In ActiveWorkbook.Sheets
If sh.Visible = xlSheetVisible Then....

As Hans Schraven says - technically it's quicker to use an array. I use a similar system to find parts from a parts database and the array system is over 100 times quicker (the list box can have up to 1,000 entries).

Ian

By: Hans Schraven

Hans Schraven — Tue, 24 Feb 2009 22:27:00 +0000

I suspect you could speed up the whole thing not using the additem method
Instead I'd suggest to use a matrix that can be loaded into the listbox .list=sq
I rewrote your application so that all the necessary code would be part of the userform. No other modules involved.

Private Sub tbxWhat_AfterUpdate()
On Error Resume Next
If tbxWhat.Text = "" Then Exit Sub
lblWarning.Caption = ""
lblMessage.Caption = ""

ReDim sq(100, 2)
For Each sh In ActiveWorkbook.Sheets
lblWarning.Caption = Val(lblWarning.Caption) + sh.UsedRange.Cells.Count
c1 = ""
c2 = ""
Do
If c1 = "" Then
c1 = sh.UsedRange.Find(tbxWhat.Text, , xlValues, xlPart).Address
Else
c1 = sh.UsedRange.Find(tbxWhat.Text, sh.Range(c1), xlValues, xlPart).Address
End If
If Err.Number > 0 Then Exit Do

If c1 = c2 Then Exit Do
If c2 = "" Then c2 = c1
With lblMessage
sq(Val(.Caption), 0) = sh.Range(c1)
sq(Val(.Caption), 1) = c1
sq(Val(.Caption), 2) = sh.Name
.Caption = Val(.Caption) + 1
End With
Loop Until Val(lblMessage.Caption) > UBound(sq)
Err.Clear
If Val(lblMessage.Caption) > UBound(sq) Then Exit For
Next
lbxFound.List = sq

With lblMessage
.ForeColor = IIf(Val(.Caption) > UBound(sq), vbRed, vbBlue)
.Caption = "Cells Found: " & IIf(Val(.Caption) > UBound(sq), ">", "") & .Caption
End With

lblWarning.Caption = "Cells to search: " & Format(lblWarning.Caption, "#,##0")
End Sub

By: Dick Kusleika

Dick Kusleika — Fri, 20 Feb 2009 16:23:00 +0000

Fixed. Thanks Peter.

By: Peter Grebenik

Peter Grebenik — Fri, 20 Feb 2009 10:57:00 +0000

In Excel2003, an error is generated if the text in the found cell is longer than 2047 characters. You can replace the problem line in Private Sub FillResults with Me.lbxFound.AddItem Left$(rFound.Value, 2047).

This is yet another example of where there are undocumented and different limits to the lengths of text strings that various Excel objects and methods can deal with.

By: Dick Kusleika

Dick Kusleika — Thu, 19 Feb 2009 21:08:00 +0000

Private Sub tbxWhat_AfterUpdate()

If Me.IsLargeSearch Then
FillResults
End If

End Sub

Private Sub tbxWhat_Change()

If Not Me.IsLargeSearch Then
FillResults
End If

End Sub

Yeah, that seems to work. Downloadable file updated.

By: Dick Kusleika

Dick Kusleika — Thu, 19 Feb 2009 15:37:00 +0000

If the workbook has more than 500k cells, I should use the AfterUpdate event. If less, use the Change event. What do you think of that?

By: Harald Staff

Harald Staff — Thu, 19 Feb 2009 12:38:00 +0000

… and the Keydown to stop it. Does require a boolean test in the search loop, so it won’t speed it up I guess.

By: Jan Karel Pieterse

Jan Karel Pieterse — Wed, 18 Feb 2009 17:58:00 +0000

You might consider using the keyup event to initiate the search…