Comments on: Lessons in SQL

By: Dick Kusleika

Dick Kusleika — Fri, 05 Dec 2008 23:40:00 +0000

Jamie: Good point. None of the parameters in my app are exposed to the user, but that’s not say they won’t be in some future application. It’s good practice to use Paramter objects, so I think I’ll start doing that.

By: Brett

Brett — Tue, 18 Nov 2008 14:31:00 +0000

Totally FUN! Removing a hyphen solved the problem. However, some of the data has a double quote as part of the value, as well as some having a single quote. Anyone have a suggestion for a bullet-proof text indicator so I can wrap that around the cell value as it is read into the Access table?

Brett

By: Brett

Brett — Tue, 18 Nov 2008 02:43:00 +0000

Andy,

Thanks very much for the link, I'm playing with the ADO flavor. It has been most timely. I can't find the secret to getting all my column names in as field names without a "Syntax Eror in Make Table" I get plenty of test tables made. The string is less than 256 characters. Any tips would be apreciated. It has been lots of fun to work with.

Brett

By: Jamie Collins

Jamie Collins — Mon, 17 Nov 2008 10:47:00 +0000

Dick, I don’t know how your code is being used but, on the face of it, it has SQL injection issues (http://en.wikipedia.org/wiki/SQL_injection). Better IMO to use stored procs or prepared statements e.g. use ADODB.Paramter objects to strongly-type the (String) values passed and return a ADODB.Command object, rather than returning dynamic SQL text.

By: Jamie Collins

Jamie Collins — Mon, 17 Nov 2008 10:42:00 +0000

Shouldn’t this be ‘Lessons in Access’? Your use of Nz() in VBA code is the giveaway

By: Rob Bruce

Rob Bruce — Sat, 15 Nov 2008 15:01:00 +0000

I prefer to code param queries in Access or stored procs in SQLServer and not to build in-line SQL in code.

Several years ago I had a class generator that I could point at a database table and it would build a class and collection that modelled the table. It wasn't perfect as it didn't understand autonumbers and sometimes got data types wrong, but it saved a lot of time and grunt-work. I lost it after I reformatted one time. The licensing no longer worked, and the developer had disappeared. Very frustrating.

Rob

By: Andy Wiggins

Andy Wiggins — Sat, 15 Nov 2008 10:30:00 +0000

Anyone reading your posting and who is interested in getting to grips with SQL, Excel and Access, might find the following link of interest.

"Using SQL in VBA" at
http://bygsoftware.com/Excel/SQL/UsingSql.html

The code creates an Access database, creates a table, inserts records into the table, amends the records, deletes the records, deletes the table and, finally, deletes the database.

In this one demonstration, you have the complete database lifecycle.

There are two downloads associated with it: one for DAO and the other for ADO.

I would make one comment about your code. SQL loves spaces and if you don't have spaces in the right places the code won't work. This caught me out a number of times until I started putting a space at the beginning of each line so the code looks like this and you can eyeball it for sense:

vtSql = ""
vtSql = vtSql & " UPDATE LatestPrices"
vtSql = vtSql & " SET " & aa & "=" &
vtSql = vtSql & " WHERE " & bb & "=""" & xx & """"

Cheers
Andy Wiggins