Comments on: My Coding Technique

By: Jerry Betz

Jerry Betz — Mon, 15 Sep 2008 16:55:00 +0000

Jon Peltier – Thank you very much.

By: Jon Peltier

Jon Peltier — Sun, 14 Sep 2008 23:19:00 +0000

If wks.OLEObjects("CheckBox1?).Object.Value = True Then MsgBox "True"

or simply

If wks.OLEObjects("CheckBox1?).Object.Value Then MsgBox "True"

By: Jerry Betz

Jerry Betz — Sun, 14 Sep 2008 02:52:00 +0000

Nick,

Thank you for sharing your technique. I admit to starting out as Phase I, and perhaps operating today in between your Phase II and the technique you outlined. I have gone back to look at the last macro I worked on, and find that your technique indeed would have kept me out of a lot of trouble. One question that I have is regarding check boxes from the control menu, in the past I would use:

If ActiveSheet.CheckBox1.Value = True Then MsgBox "True"

However, that errors out when I try to use your technique:

Sub wbwksvariables()

Dim wb As Workbook
Dim wks As Worksheet

Set wb = ActiveWorkbook
Set wks = wb.ActiveSheet

If wks.CheckBox1.Value = True Then MsgBox "True"

End Sub

I find that intellisense will lead me to OLEObjects, and have tried:

If wks.OLEObjects(CheckBox1).Value = True Then MsgBox "True"

and

If wks.OLEObjects("CheckBox1").Value = True Then MsgBox "True"

but haven't been able to get either of those to work. Thanks for your help.

By: Stephanie Smith

Stephanie Smith — Thu, 21 Aug 2008 18:41:00 +0000

@jmbob666: Basically “subscript out of bounds” means the code has tried to access an item in an array, and the item doesn’t exist. Make sure your worksheets collection actually has a sheet in it named “Sheet1?.

By: jmbob666

jmbob666 — Wed, 20 Aug 2008 19:32:00 +0000

This would be really useful to me if I could get it to work. I’m using Excel 2003 and I get a subscript out of bounds error (runtime error 9) when it hits: Set wks = wb.Worksheets(“Sheet1?). Anyone have an idea why?

By: Harald Staff

Harald Staff — Tue, 19 Aug 2008 08:44:00 +0000

Thanks Jan Karel. Now I’m confused again BG…
Seems that Listobject won’t work for files made in older versions, while Connections does. In native 12 files, both methods seem to access the same object.

By: Jon Peltier

Jon Peltier — Tue, 19 Aug 2008 04:20:00 +0000

Jan Karel – OCD = “obsessive-compulsive disorder”. If it’s really bad, it’s CDO, so the letters are in alphabetical order.

By: fzz

fzz — Mon, 18 Aug 2008 20:13:00 +0000

Tushar Mehta - consider using a soundex or approximate matching function rather than exact matching to locate possibly slightly altered header strings if no exact match were found. Display the close but not exactly equal headers in a listbox in a dialog, and allow the user to select the 'correct' one.

The exact header strings and/or possibly matching regular expression patterns should be constants in the module code.

By: Tushar Mehta

Tushar Mehta — Mon, 18 Aug 2008 19:21:00 +0000

@Dan Maxey: Yes, it helps to use constants to identify columns in external data sources. But, consider taking it a step further. Recently, I completed a project where the client received data for 8 (expected to increase to 12 or 15) data sources from different corporate groups around the world. Every month someone added / moved some data from some column to another. Not to mention the location of the header row also shifted. My solution was to create a function that located a column based on a header string. Now, as long as the header strings remained intact, the code could adjust to headers being in an arbitrary row (obviously with preceding rows being blank) and data being in arbitrary columns. Further, by building a map of the layout “up front” the code could gracefully fail if it found a header to be missing.

By: jkpieterse

jkpieterse — Mon, 18 Aug 2008 18:44:00 +0000

Harold: Querytables are now children of the ListObject object.