Comments on: Page update: Copy a range from closed workbooks (ADO)

By: Joost

Joost — Mon, 21 Jul 2008 21:19:00 +0000

Getting data from closed workbooks with the macro from Ron de Bruin works great for me. Especially since I have a folder containing a changing number of source files. However, I do notice two minor issues: dynamic named ranges cannot be used with the “getdata” macro and columns containing dates seem to be difficult to transfer (only works when source file is open). Does anybody have some ideas how to get around these issues? Thanks in advance!

By: Ron de Bruin

Ron de Bruin — Mon, 31 Dec 2007 15:12:00 +0000

Hi Alex

I don't think it is possible with dynamic range names but I good be wrong.
Maybe others can tell us if it is possible.

By: Alex J

Alex J — Mon, 31 Dec 2007 00:35:00 +0000

Ron,
Thanks for the update. My quick test confirms that this works just fine. I will incorporate into more stringent testing for full confirmation.

Also, I am assuming from my tests that the closed workbook access method will not can not) work for dynamic named ranges - can you confirm this? The obvious workaround for that is to construct static 'Export Ranges' from the dynamic ranges to support closed wb access.

By: Ron de Bruin

Ron de Bruin — Mon, 31 Dec 2007 00:10:00 +0000

I changed the download on my page with the new function.

Good night

By: Ron de Bruin

Ron de Bruin — Sun, 30 Dec 2007 21:20:00 +0000

Hi Alex

This seems to work OK for me (fast test)
Test it for me and let me know

Change the szSQL line in the function to this

If SourceSheet = "" Then
' workbook level name
szSQL = "SELECT * FROM " & SourceRange$ & ";"
Else
' worksheet level name
szSQL = "SELECT * FROM [" & SourceSheet$ & "$" & SourceRange$ & "];"
End If

If you not fill in a sheet name in the macro it use the workbook level name.
Will test more this week and update the page

By: Ron de Bruin

Ron de Bruin — Sat, 29 Dec 2007 13:35:00 +0000

Hi Alex

Yes this is possible.
I will try to add a example next week to the page.
To much work on this moment to do it this weekend (must work the whole weekend)

By: Alex J

Alex J — Sat, 29 Dec 2007 00:02:00 +0000

Ron,
I am trying to use your GETDATA routine with named ranges on a closed workbook. I can make it work on the named range when the source workbook is open, but the same call fails when the source workbook is closed. The call DOES work if i replace the range name with the range address in the GETDATA function call. Note: The named range refers directly to an address - it is not a formula.

Should this be possible?

By: MacroMan

MacroMan — Mon, 24 Dec 2007 17:19:00 +0000

Thanks Ron. I was also thinking of looping this SQL:

sSQL = “INSERT INTO Store (TIMEIN, MYDATE, MYSESSION, MANAGER, ” & _
“LEADNUMBER, CONSULTANT, PRIZE, ” & _
“ACTUALNUMBER, CHOSENNUMBER, TIMEOUT, ” & _
“DIFFERENCE, SURNAME) ” & _
“VALUES (‘” & [A2].Text & “‘,’” & [B2].Text & “‘,’” & [C2].Text & _
“‘,’” & [D2].Text & “‘,’” & [E2].Text & “‘,’” & [F2].Text & _
“‘,’” & [G2].Text & “‘,’” & [H2].Text & “‘,’” & [I2].Text & _
“‘,’” & [J2].Text & “‘,’” & [K2].Text & “‘,’” & [L2].Text & “‘)

Of course I’ll replace the “[]” with “Cells(i, x)”. I’ll try them both when I get back to work. Happy Holidays!

By: Ron de Bruin

Ron de Bruin — Mon, 24 Dec 2007 16:58:00 +0000

Hi MacroMan

Never try this with a closed Excel workbook
Maybe Ole have something for you on his site
http://www.erlandsendata.no/english/index.php?t=envbadac

By: MacroMan

MacroMan — Mon, 24 Dec 2007 07:11:00 +0000

Anyone know how to import data from a closed Excel workbook into an Access table, both having the same fields, with SQL/ADO? Something with INSERT/SELECT?