Comments on: CEILING Part 3

By: Parker Kimm

Parker Kimm — Sat, 23 Jun 2007 01:13:00 +0000

Case "22?
Debug.Assert nrL = srL And ncL = scL
If nrU = srU And ncU = scU Then
ReDim vRes(nrL To nrU, ncL To ncU)
For r = nrL To nrU: For c = ncL To ncU: vRes(r, c) = GetCeiling(vNum(r, c), vSig(r, c)): Next: Next
Else
Dim nrX As Long, srX As Long, ncX As Long, scX As Long
If nrU = 1 Then nrU = srU Else nrX = 1
If srU = 1 Then srU = nrU Else srX = 1
If ncU = 1 Then ncU = scU Else ncX = 1
If scU = 1 Then scU = ncU Else scX = 1
nrU = Application.Max(nrU, srU)
ncU = Application.Max(ncU, scU)
ReDim vRes(nrL To nrU, ncL To ncU)

For r = 0 To nrU - nrL
For c = 0 To ncU - ncL
vRes(nrL + r, ncL + c) = CVErr(xlErrNA)
vRes(nrL + r, ncL + c) = GetCeiling(vNum(nrL + r * nrX, ncL + c * ncX), vSig(srL + r * srX, scL + c * scX))
Next
Next
End If

By: keepITcool

keepITcool — Fri, 22 Jun 2007 10:54:00 +0000

Yep, missed that. Repaired "case 22? as follows:

Case "22"
Debug.Assert nrL = srL And ncL = scL
If nrU = srU And ncU = scU Then
ReDim vRes(nrL To nrU, ncL To ncU)
For r = nrL To nrU: For c = ncL To ncU: vRes(r, c) = GetCeiling(vNum(r, c), vSig(r, c)): Next: Next
Else
Dim nrX As Long, srX As Long, ncX As Long, scX As Long
If nrU = 1 Then nrU = srU Else nrX = 1
If srU = 1 Then srU = nrU Else srX = 1
If ncU = 1 Then ncU = scU Else ncX = 1
If scU = 1 Then scU = ncU Else scX = 1
nrU = Application.Max(nrU, srU)
ncU = Application.Max(ncU, scU)
ReDim vRes(nrL To nrU, ncL To ncU)

For r = 0 To nrU - nrL
For c = 0 To ncU - ncL
vRes(nrL + r, ncL + c) = CVErr(xlErrNA)
vRes(nrL + r, ncL + c) = GetCeiling(vNum(nrL + r * nrX, ncL + c * ncX), vSig(srL + r * srX, scL + c * scX))
Next
Next
End If

Remaining challenge
return #Value! for non array-entered arrays, BUT return array in editmode

If IsArray(vRes) Then
With Application
If TypeOf .Caller Is Range Then If Not .Caller.HasArray Then vRes = CVErr(xlErrValue)
End With
End If

however return vRes in editmode.. I've tried Application.Ready (xp+) but it doens't work.

By: fzz

fzz — Fri, 22 Jun 2007 00:42:00 +0000

The problem is in Case "22?. Specifically, when vNum is M-by-N and vSig is M-by-1,

For c = ncL To ncU
If c <&eq; UBound(vNum, 2) And c <&eq; UBound(vSig, 2) Then

The problem is that ncL = 1, ncU = 2, and UBound(vNum, 2) = 2, BUT UBound(vSig, 2) = 1. That means that on the second iteration when c = 2, the second test above fails, which leads to an #N/A entry in the result array.

You made nrU = 1 and scU = 1 special cases. You should also have made ncU = 1 and scU = 1 special cases. But that doesn't fix things. With {8,7.5;10,10} in D3:E4 and {2,2.5,} in D1:F1,

=kicceiling(D3:E4,D1:F1)

returns {8,10,0;10,10,0} while

=CEILING($D$3:$E$4,$D$1:$F$1)

returns {8,7.5,#N/A;10,10,#N/A}, so you still have a bug in your array iteration AND you have a bug in GetCeiling.