I’m staring at the “Save changes” query. I take that to mean (after some experimentation) that Workbook_BeforeClose has run. And that Dick’s one second delay has timed out. So both Workbook_Deactivate and CheckifClosed are pending. Since the code does work, that means Workbook_Deactivate has to go next if I choose anything but Cancel. Why?? Well, because, of course. Where is the pecking order of macros highlighted? Checking Chip Pearson’s Event Sequence, standard module macros (or at least Auto_close does) run before Workbook_deactivate, meaning CheckifClosed should do its thing (which as I said, it doesn’t).

Can anybody help me fully understand the flow when Cancel isn’t the choice? Thanks.

…Michael

Sub UnprotectSh()
‘make sure only one sheet is selected before running this sub or it fails
Sheets(“insert the name of one of your sheets here…”).Select

Dim sheetCount As Integer
Dim i As Integer

‘count how many sheets there are in the workbook
sheetCount = Worksheets.Count

‘unprotect each sheet number until the sheetCount is reached
For i = 1 To sheetCount
Sheets(i).Unprotect
Next i

End Sub

Sub Unlocks_All()

‘ Unlocks everything, be careful using this..
‘ You must run the UnprotectSh sub first so that all of the sheets can be selected

‘select every cell on every sheet and substitute these sheet names with yours,
‘recording a macro and selecting all of the sheets is the easiest way..
Sheets(Array(“Year to Date Summary”, “January”, “February”, “March”, “April”, “May”, _
“June”, “July”, “August”, “September”, “October”, “November”, “December”)).Select
Sheets(“Year to Date Summary”).Activate
Cells.Select
Range(“A1?).Activate

‘unlocks the selected cells and ensure that formulas *can* be seen
Selection.Locked = False
Selection.FormulaHidden = False

‘select only one cell so that it’s neater, again, substitute your values
Sheets(“Year to Date Summary”).Select
Range(“A1?).Select

End Sub

Remember to lock everything down again when on Workbook_Open, I use a Locks_All and ProtectSh in that order and they’re basically the reverse of the unlock and unprotect. Good luck!

And, no, it would not be OK — as some klutz in some other discussion wrote s/he would do — to simply set the WB’s Saved property to True, which I imagine would mean Excel would not ask the user if the WB should be saved. There are any number of times when I close a document expecting the program to ask me if it should be saved.

Of course, this presumes that it is OK to programmatically save the file after Excel has initiated the close process.

For my case, some cells are locked & protected during open. And I need to release the locks and protection before close the file.

My issue is if the user close the worksheet but not save, how can I save my lock / protection release setup information.

Please help. Thanks.

Kristin,

If your issue has to do with just creating and deleting the commandbar at the correct time, try just using the activate and deactivate events. They fire when the workbook opens and closes, respectively, and deactivate avoids the problem Dick mentions above. If, on the other hand, you need to distinguish between actions that happen at close and those that happen at deactivate, you need to do something like above.

If you do have an event that you want to only happen at close, you should do like Dick suggests above. I don’t use the OnTime method, I just set the gbClosing in the Deactivate and BeforeClose events.

Here’s what I’d do to cover both the menu creation/deletion on Activate/Deactivate and what I’ll call the ReallyClose event. This is all in the ThisWorkbook module:

Public gbClosing As Boolean

Private Sub Workbook_Activate()
Dim cb As CommandBar
Dim cbb As CommandBarButton

On Error Resume Next
Application.CommandBars(“MyBar”).Delete
On Error GoTo 0
Set cb = Application.CommandBars.Add(“MyBar”)
Set cbb = cb.Controls.Add(msoControlButton)
cbb.Caption = “Tester”
cbb.Style = msoButtonCaption
cb.Visible = True
End Sub

Private Sub Workbook_Deactivate()
On Error Resume Next
Application.CommandBars(“MyBar”).Delete
MsgBox “Deactivate”
On Error GoTo 0
If gbClosing Then
MsgBox “ReallyClose”
End If
gbClosing = False
End Sub

Private Sub Workbook_BeforeClose(Cancel As Boolean)
gbClosing = True
End Sub

You should know that I have bad luck in trying to improve on Dick’s code – I’m usually wrong . But try for yourself and see what you think.

could anybody please help me to understand this tutorial. I don’t get the part where the onTime function calls ‘CheckIfClosed’ and sets the value off gbClosing to false. Does this also work without the the ‘CheckIfClosed’ function? Or shouldn’t the gbClosing be set to true in the function ‘CheckIfClosed’ to make this work?

Please help me to understand it better, I need this to solve exactly the same problem with a selfmade commandbar.

Thanks,
Kristin