Also had a problem with the “-1″ at the end of line “For i = LBound(vaItems, 1) To UBound(vaItems, 1) – 1″, remove the -1 and the code is perfect.

Thank you very much!

Instead of

I’m pointing this out in case somebody else overlooked the comments like I did.

I had the same problem as Aaron- “object required.” I was confused about Julian’s comment- make sure WHAT is MSForms.ListBox? I copy and pasted the code and assume he was talking about the function argument.

My problem was from using parenthesis to call the function:

WRONG: SortListBox(MyForm.MyListBox)
RIGHT: SortListBox MyForm.MyListBox

Apparently this is a VBA quirk that I have not encountered in the past.

Thanks for the script. Even with the time spent troubleshooting I’m sure it saved me an hour or so.

Note that Listboxes treat their items as character strings, so the comparison as written above:
vaItems(i, 0) > vaItems(j, 0)
is a string comparison. Even if you put in numbers when you call Listbox.Add(), the Listbox will convert them to strings for storing internally, and so will give you back an array of strings when you call Listbox.List() (and that array is what is getting sorted).

To sort the data in numerical order, you need to make numeric comparisons, so you need to convert the items in the array to numbers (such as integers) before comparing them, something like:
CInt(vaItems(i, 0)) > CInt(vaItems(j, 0))

However, you should choose the appropriate conversion function for your data. If you are sure your data are relatively small integers (less than 2 billion), CInt() will suffice, but very large numbers will require CLng(), and numbers that have decimal components will require CDec() (for exact decimal comparison) or CDbl() (for approximate decimal comparison).

After the comparison, it’s not necessary to treat the data as numbers anymore, so the rest of the code remains the same.